Fix 1.20.2 login, enable 1.20.2 support, edit TODO

1.20.2 still seems to have an odd issue with BungeeCord where
ServerConnectedEvent is not called?...

Author: retrixe

README.md

@@ -9,7 +9,7 @@ Disclaimer: This app is NOT an official Minecraft product. It is not associated
 ## Features (still being worked on)
 
 - Fully open-source with no ads! Easily report issues through GitHub and get a direct response.
-- Supports connecting to Minecraft 1.16.4 through Minecraft 1.20.1 servers. (Older versions planned.)
+- Supports connecting to Minecraft 1.16.4 through Minecraft 1.20.2 servers. (Older versions planned.)
 - Supports all Minecraft chat features, which sometimes trip up other chat apps.
 - Send join messages and commands on connecting to a server.
 - Health change indicator and respawn on death support.

src/components/servers/EditServerDialog.tsx

@@ -106,6 +106,7 @@ const EditServerDialog = ({
         dropdownIconColor={darkMode ? '#ffffff' : '#000000'}
       >
         <Picker.Item label='Auto' value='auto' />
+        <Picker.Item label='1.20.2 (WIP)' value='1.20.2' />
         <Picker.Item label='1.20/1.20.1 (WIP)' value='1.20.1' />
         <Picker.Item label='1.19.4 (WIP)' value='1.19.4' />
         <Picker.Item label='1.19.3 (WIP)' value='1.19.3' />

src/minecraft/connection/shared.ts

@@ -56,11 +56,16 @@ export const getLoginPacket = (opts: ConnectionOptions): Buffer => {
     } */
   }
   if (opts.protocolVersion >= protocolMap['1.19.1']) {
+    if (opts.protocolVersion < protocolMap['1.20.2']) {
+      data.push(concatPacketData([!!opts.selectedProfile]))
+    }
     if (opts.selectedProfile) {
       const msb = Buffer.from(opts.selectedProfile.substring(0, 16), 'hex')
       const lsb = Buffer.from(opts.selectedProfile.substring(16), 'hex')
-      data.push(concatPacketData([true, msb, lsb]))
-    } else data.push(concatPacketData([false]))
+      data.push(concatPacketData([msb, lsb]))
+    } else if (opts.protocolVersion >= protocolMap['1.20.2']) {
+      data.push(concatPacketData([Buffer.alloc(8), Buffer.alloc(8)]))
+    }
   }
   return concatPacketData(data)
 }

src/minecraft/utils.ts

@@ -18,7 +18,7 @@ export const protocolMap = {
   '1.20': 763,
   '1.20.1': 763,
   '1.20.2': 764,
-  latest: 763,
+  latest: 764,
   auto: -1
 }
 

src/utilities/connection/packetHandler.ts

@@ -105,7 +105,7 @@ export const packetHandler =
     const is118 = version >= protocolMap[1.18]
     const is1191 = version >= protocolMap['1.19.1']
 
-    // FIXME: 1.20.2 also has a second Client Information in configuration state.
+    // LOW-TODO: 1.20.2 also has a second Client Information in configuration state, do we send it?
     if (connection.state === ConnectionState.PLAY) {
       if (
         packet.id === packetIds.CLIENTBOUND_LOGIN_SUCCESS(version) ||
@@ -120,7 +120,7 @@ export const packetHandler =
         viewDistance.writeInt8(2)
         const skinParts = Buffer.alloc(1)
         skinParts.writeUInt8(0b11111111)
-        // TODO: Intl in future? And other setting changes too.
+        // LOW-TODO: Intl in future? And other setting changes too.
         const packetData: PacketDataTypes[] = [
           'en_US',
           viewDistance,
@@ -152,8 +152,7 @@ export const packetHandler =
         }
       } else if (packet.id === packetIds.CLIENTBOUND_RESPAWN(version)) {
         // Send spawn command when switching worlds.
-        // FIXME: This packet is not recv when switching worlds on Velocity...
-        // Perhaps we track dimension ID or something and equate the two or something?
+        // TODO: Velocity doesn't send this, only Login on switching worlds. Track dimension?
         if (sendSpawnCommand) {
           connection
             .writePacket(...makeChatMessagePacket('/spawn', version))