Integrate Maven builds and GH actions setup #1414
Conversation
…ing, added support for deploying packages to GH packages as well as Maven central. Harden plugins configs. Fixed links to licenses, websites, etc.
|
@jlouvel, can you please review this? Please let me know how can I share the JCA. |
|
Thanks a lot @xSAVIKx this looks great! |
| @@ -0,0 +1,12 @@ | |||
| # Set default behavior to automatically normalize line endings. | |||
.gitattributes
Outdated
| # in Windows via a file share from Linux, the scripts will work. | ||
| *.{cmd,[cC][mM][dD]} text eol=crlf | ||
| *.{bat,[bB][aA][tT]} text eol=crlf | ||
| *.{ics,[iI][cC][sS]} text eol=crlf |
There was a problem hiding this comment.
hum, I wonder why we should take such files into consideration?
I'm not an expert, but ics files are calendar files, aren't they?
There was a problem hiding this comment.
This is just an auto-generated template. I can drop that particular one if you prefer.
There was a problem hiding this comment.
Hi @xSAVIKx
do you mind to drop it?
|
|
||
| # Force bash scripts to always use LF line endings so that if a repo is accessed | ||
| # in Unix via a file share from Windows, the scripts will work. | ||
| *.sh text eol=lf |
pom.xml
Outdated
| <url>http://restlet.tigris.org/svn/restlet/modules/</url> | ||
| <url>https://github.com/restlet/restlet-framework-java.git</url> | ||
| <connection>scm:git:${project.scm.url}</connection> | ||
| <developerConnection>scm:git:${project.scm.url}</developerConnection> | ||
| </scm> | ||
|
|
||
| <repositories> |
There was a problem hiding this comment.
I think we can drop the repositories section. TheRestlet repository is useful only for 2.4 and below versions of the the framework.
There was a problem hiding this comment.
I believe it should be stated here while you're still gonna publish there as well, right?
There was a problem hiding this comment.
oh, I have to tell you we want to publish to Maven Central for 2.5 versions and higher. That's why I'm inclined to drop the repositories section.
Does it sound correct to you?
| *.iml | ||
| .DS_Store | ||
| .idea | ||
| target | ||
| .classpath | ||
| .project | ||
| .settings | ||
| *.class |
| @@ -1,5 +1,13 @@ | |||
| # Restlet Framework | |||
|
|
|||
|
|
|||
Co-authored-by: Thierry Boileau <[email protected]>
|
@thboileau please take a look again. I believe I've answered/resolved all the open points |
|
hi @xSAVIKx |
|
@thboileau resolved 👍 |
|
Thx for the review. FYI, I don't have a way to merge this, so that's on you guys. |
In this PR I have copied over all the relevant Maven and GH actions-related changes I introduced in my fork: