Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #10

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Refactor #10

merged 1 commit into from
Apr 7, 2023

Conversation

erasin
Copy link
Contributor

@erasin erasin commented Mar 27, 2023

I rewrote the request part, modified the json_body , and appended the xml_body.

It's perfectly work with helix editor.

@NTBBloodbath
Copy link
Member

Hey, I'm loving all the changes but why did you remove embedded JSON parser and rolled out a custom one? Just being curious there.

Cheers

@erasin
Copy link
Contributor Author

erasin commented Mar 27, 2023

The reason is that like vim, helix tree-sitter has support injections.scm, by setting injections to support json, xml, reduce the size of the compiled file.

@NTBBloodbath
Copy link
Member

NTBBloodbath commented Apr 7, 2023

Woops, I've been somewhat busy and completely forgot to merge this one, my apologies!

Thank you so much again for the changes!

@NTBBloodbath NTBBloodbath merged commit 77bc7b2 into rest-nvim:main Apr 7, 2023
@erasin
Copy link
Contributor Author

erasin commented Apr 8, 2023

Thanks merged.
In helix pr, use hurl replace rest-client.
Because helix not support plugins now, and the hurl support cli and chaining request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants