Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: update required lua version up to actual 5.4 #477

Open
1 task done
tony-sol opened this issue Sep 29, 2024 · 5 comments
Open
1 task done

Feature: update required lua version up to actual 5.4 #477

tony-sol opened this issue Sep 29, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@tony-sol
Copy link

Issues

  • I have checked existing issues and there are no existing ones with the same request.

Feature description

According to dependencies, rest.nvim requires "lua >= 5.1, < 5.4", but while i'm trying to use it with lua 5.3.6 it always causes an warning

`lua` version `5.1` needed, but found `Lua 5.3.6  Copyright (C) 1994-2020 Lua.org, PUC-Rio`
@tony-sol tony-sol added the enhancement New feature or request label Sep 29, 2024
@boltlessengineer
Copy link
Contributor

boltlessengineer commented Sep 30, 2024

I haven't really test this plugin with lua version other than 5.1 and Neovim only supports lua 5.1 via LuaJIT (:h lua) so "lua == 5.1" might make more sense.

I guess @NTBBloodbath set it to "lua >= 5.1 < 5.4" because those lua versions are somewhat similar.

Btw the lua version 5.1 requirement is from your package manager and not from rest.nvim. You need lua 5.1 in your system to properly install this plugin via luarocks.

Both lazy.nvim and rocks.nvim should handle this lua dependency automatically.
What neovim plugin manager are you using to install rest.nvim?

Edit: correct

@tony-sol
Copy link
Author

Both lazy.nvim and rocks.nvim should handle this lua dependency automatically. What neovim plugin manager are you using to install rest.nvim?

lazy.nvim

@boltlessengineer
Copy link
Contributor

You can 1) manually install lua5.1 in your machine or 2) force lazy.nvim to use hererocks to install all lua & luarocks by itself.

For second method, your lazy.nvim setup will look like this:

require("lazy").setup({
  spec = {
    -- your plugin specs
  },
  rocks = {
    enabled = true,
    hererocks = true,
  },
})

@tony-sol
Copy link
Author

Thx, i'll switch to 5.1, btw is 5.1.5 ok? Is it bounded only to minor version, or also to patch?

@boltlessengineer
Copy link
Contributor

lua in your system is only used to install the plugin no many stuffs happening there. 5.1.5 is fine, I'm also using that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants