Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐞] Time Travel plugin is not thread-safe when mutating collections. #48

Closed
Nek-12 opened this issue Mar 23, 2024 · 0 comments · Fixed by #63
Closed

[🐞] Time Travel plugin is not thread-safe when mutating collections. #48

Nek-12 opened this issue Mar 23, 2024 · 0 comments · Fixed by #63
Assignees
@Nek-12
Labels
bug Something isn't working
Milestone
3.0

Comments

@Nek-12
Copy link
Member

Nek-12 commented Mar 23, 2024

We should use either synchronized collections or immutable collections to mutate the values. A simple "atomic" does nothing in our case.
@Nek-12 Nek-12 added bug Something isn't working triage Needs triaging labels Mar 23, 2024
@Nek-12 Nek-12 self-assigned this Mar 23, 2024
@Nek-12 Nek-12 removed the triage Needs triaging label Mar 23, 2024
@Nek-12 Nek-12 added this to the 3.0 milestone Apr 25, 2024
@Nek-12 Nek-12 mentioned this issue Apr 25, 2024
Merged
@Nek-12 Nek-12 linked a pull request Apr 25, 2024 that will close this issue
2.5.0-alpha11 #63
Merged
@Nek-12 Nek-12 closed this as completed in a3581b1 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nek-12 Nek-12

Labels
bug Something isn't working
Projects
FlowMVI Roadmap
Archived in project
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

2.5.0-alpha11 respawn-app/FlowMVI
1 participant
@Nek-12