Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What precludes including MLSL and MLSL_LDS for NLOptNoGrad? #332

Open
123epsilon opened this issue Jan 31, 2024 · 2 comments
Open

What precludes including MLSL and MLSL_LDS for NLOptNoGrad? #332

123epsilon opened this issue Jan 31, 2024 · 2 comments

Comments

@123epsilon
Copy link

Just wondering since I was interested in evaluating MLSL and MLSL_LDS as acquisition optimization functions, what makes their implementation different from the algorithms already present in the NLOptNoGrad file? Is it the necessity for a local optimizer?

I'd be willing to implement this but I'm just curious why its not straightforward

@costashatz
Copy link
Member

Hello! Thanks for your interest!

I think the honest answer is that they needed a bit of extra work (because of the local optimizer) and we didn't intend to use them, so we did not put this extra effort.

Their implementation should be very much straightforward though. Feel free to propose an implementation. We'll be happy to review/accept it.

@123epsilon
Copy link
Author

Awesome, I'll see if I have some time this week to provide an implementation - thanks for the swift response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants