Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting of LIBDYNAMIXEL in CMake #31

Open
ssr-yuki opened this issue Nov 6, 2020 · 1 comment
Open

Setting of LIBDYNAMIXEL in CMake #31

ssr-yuki opened this issue Nov 6, 2020 · 1 comment

Comments

@ssr-yuki
Copy link

ssr-yuki commented Nov 6, 2020

Hi, thank you for publishing great software.

I would like to ask you why you write CMake as the following:

set(LIBDYNAMIXEL "")

In this implementation,the right hand STREQUAL of

if ("$ENV{RESIBOTS_DIR}" STREQUAL "" AND "${LIBDYNAMIXEL}" STREQUAL "")

always returns true in my understanding. So, even though I set LIBDYNAMIXEL as a environment variable, this cmake uses default settings if I do not set RESIBOTS_DIR.

I think it (Line 6) should be as the following.

set(LIBDYNAMIXEL "$ENV{LIBDYNAMIXEL}")

Regards.

@5730289021-NN
Copy link

5730289021-NN commented Aug 4, 2021

I agree on this.

Furthermore, the default location at Line 26-27

if ("$ENV{RESIBOTS_DIR}" STREQUAL "" AND "${LIBDYNAMIXEL}" STREQUAL "")
message("Using default location for libdynamixel : ~")
set(libdynamixel_dir "~")

should be

message("Using default location for libdynamixel : /usr/local/")
set(libdynamixel_dir "/usr/local/")

instead since the default install location is at there.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants