Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should unit have a special color ? #4

Open
kiuKisas opened this issue Aug 26, 2021 · 3 comments
Open

Should unit have a special color ? #4

kiuKisas opened this issue Aug 26, 2021 · 3 comments
Labels
bikeshedding Opinionated discussion

Comments

@kiuKisas
Copy link

For javascript, undefined have it's own color. I think we can have a dedicated color for unit ?

@nkrkv
Copy link
Collaborator

nkrkv commented Aug 26, 2021

I think it’s just a type name.

undefined in JS is a value of type undefined. But you cannot refer to the type undefined anyhow. I.e., when you use typeof x you compare it with a string. So, the JS case is slightly different.

Perhaps, it is a good idea to give unit the @type.builtin group rather than just @type. If so, should the bool, string, int, float get the same group too?

@nkrkv nkrkv added the bikeshedding Opinionated discussion label Aug 26, 2021
@aspeddro
Copy link
Collaborator

Why true and false are not @boolean group? int as @number and float as @float?

@nkrkv
Copy link
Collaborator

nkrkv commented Nov 17, 2021

Why true and false are not @boolean group? int as @number and float as @float?

Pretty sure it’s because highlights.scm is heavily based on JavaScript’s highlight.scm and they are done there the same way. So, no particular strong reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bikeshedding Opinionated discussion
Projects
None yet
Development

No branches or pull requests

3 participants