Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tests with bsb and move them out of jscomp #7068

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 3, 2024

After #7063, the tests in jscomp/test were not compiled anymore.

This PR

  • moves the tests from jscomp/test, jscomp/build_tests, jscomp/gentype_tests into a new top-level folder tests
  • builds the tests that used to be compiled with ninja.js with the standard rescript/bsb tooling instead. (This also includes tests that were never compiled before as they were in subdirectories of jscomp/test.)
  • removes the internal bsc option -make-runtime-test that is not needed anymore
  • renames scripts/ciTest.js to scripts/test.js
  • removes some obsolete files

@zth
Copy link
Collaborator

zth commented Oct 3, 2024

🥹

@cknitt cknitt requested review from zth and cometkim October 3, 2024 16:57
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@cknitt cknitt merged commit 6d88e98 into rescript-lang:master Oct 3, 2024
20 checks passed
@cknitt cknitt deleted the tests branch October 3, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants