Skip to content

Fix issue where an inline record with attributes did not parse. #6499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristianoc merged 1 commit into from
Nov 29, 2023
Merged

Fix issue where an inline record with attributes did not parse. #6499

cristianoc merged 1 commit into from
Nov 29, 2023

Conversation

@cristianoc
Copy link
Collaborator

@cristianoc cristianoc commented Nov 29, 2023

This did not parse without a , after the field:

type inlineWithAttrs = | A({@as("VALUE") value: string})

Fixes #6497

@cristianoc
Fix issue where an inline record with attributes did not parse.
56cc5f7 
This did not parse without a `,` after the field:

```res
type inlineWithAttrs = | A({@as("VALUE") value: string})
```

Fixes #6497
@cristianoc cristianoc requested a review from zth November 29, 2023 09:19
@cristianoc cristianoc merged commit 2a37c94 into master Nov 29, 2023
@cristianoc cristianoc deleted the inline_record_attr branch November 29, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zth zth zth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parser breaks for a variant with @as

3 participants

@cristianoc @zth