Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rewatch to build runtime, tests etc. #7117

Open
cknitt opened this issue Oct 22, 2024 · 2 comments
Open

Use rewatch to build runtime, tests etc. #7117

cknitt opened this issue Oct 22, 2024 · 2 comments

Comments

@cknitt
Copy link
Member

cknitt commented Oct 22, 2024

Since #7063 and #7068, the infamous ninja.js is gone, and runtime/stdlib and tests are built with the standard ReScript build tooling (rescript.json, rescript wrapper script, bsb/bsb_helper/ninja).

In order to eventually get rid of bsb, bsb_helper and ninja completely, we need to build all these with rewatch instead:

  • runtime
  • tests/tests
  • tests/build_tests/*
  • tests/gentype_tests/*

Note:

  • Building runtime is a bit special with -make-runtime and the resulting paths in the JS output. When I last tried it with rewatch, I wasn't able to get the same paths in the JS output.
  • Even with the standard tooling, I was only able to get it to work as required with all source files in the runtime root. But the goal would be to be able to group them into subfolders (core, belt, js, primitives, ...).

@jfrolich @rolandpeelen could you take a stab at this?

@rolandpeelen
Copy link
Member

@jfrolich -- Shall we have a chat about this the coming week / divide & conquer? I might be able to clear up some time to do some smaller tasks

@jfrolich
Copy link

Yes, same same! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

3 participants