Skip to content

Add support for pnpm #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

Add support for pnpm #1126

merged 1 commit into from
Sep 12, 2025

Conversation

nojaf
Copy link
Member

@nojaf nojaf commented Sep 12, 2025

pnpm has this as well...

@nojaf nojaf requested a review from zth September 12, 2025 11:40
zth
zth approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could set up tests for this as well in this repo. But, feels like quite the undertaking right now.

@nojaf
Copy link
Member Author

nojaf commented Sep 12, 2025

Yeah, I’m planning to set up a general runtime/package-manager/test-repo combo that’s easy for users to contribute samples to if we miss something, and that can be tested over time with https://pkg.pr.new/rescript-lang/rescript@master.

We can include a test that runs find-runtime.ts for each sample to assert it works.

@nojaf nojaf merged commit 01a4a81 into rescript-lang:master Sep 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nojaf @zth