Fix hover on components in interface files.

Fixes #153

Author: cristianoc

analysis/src/Commands.ml

@@ -70,8 +70,9 @@ let hover ~file ~line ~col ~extra ~package =
       match uriLocOpt with
       | None -> false
       | Some (_, loc) ->
+        let isInterface = file.uri |> Uri2.isInterface in
         let posIsZero {Lexing.pos_lnum; pos_bol; pos_cnum} =
-          pos_lnum = 1 && pos_cnum - pos_bol = 0
+          (not isInterface) && pos_lnum = 1 && pos_cnum - pos_bol = 0
         in
         (* Skip if range is all zero, unless it's a module *)
         (not locIsModule) && posIsZero loc.loc_start && posIsZero loc.loc_end
@@ -111,8 +112,9 @@ let definition ~file ~line ~col ~extra ~package =
     match uriLocOpt with
     | None -> Protocol.null
     | Some (uri2, loc) ->
+      let isInterface = file.uri |> Uri2.isInterface in
       let posIsZero {Lexing.pos_lnum; pos_bol; pos_cnum} =
-        pos_lnum = 1 && pos_cnum - pos_bol = 0
+        (not isInterface) && pos_lnum = 1 && pos_cnum - pos_bol = 0
       in
       (* Skip if range is all zero, unless it's a module *)
       let skipZero =

analysis/src/Uri2.ml

@@ -5,6 +5,8 @@ module Uri : sig
 
   val fromPath : string -> t
 
+  val isInterface : t -> bool
+
   val stripPath : bool ref
 
   val toPath : t -> string
@@ -30,6 +32,8 @@ end = struct
     let path = Files.maybeConcat (Unix.getcwd ()) localPath in
     fromPath path
 
+  let isInterface {path} = Filename.check_suffix path "i"
+
   let toPath {path} = path
 
   let toString {uri} = if !stripPath then Filename.basename uri else uri

analysis/tests/src/expected/Jsx.resi.txt

@@ -1,5 +1,5 @@
 Hover tests/src/Jsx.resi 1:4
-null
+{"contents": "```rescript\n(~first: string, ~?key: string, unit) => {\"first\": string}\n```"}
 
 Hover tests/src/Jsx.resi 4:4
 {"contents": "```rescript\nint\n```"}