Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f64 depth images aren't displayed in the UI #635

Closed
nikolausWest opened this issue Dec 23, 2022 · 3 comments
Closed

f64 depth images aren't displayed in the UI #635

nikolausWest opened this issue Dec 23, 2022 · 3 comments
Assignees
@emilk
Labels
good first issue Good for newcomers ui concerns graphical user interface

Comments

@nikolausWest
Copy link
Member

nikolausWest commented Dec 23, 2022 •
edited
Loading

After #608 f64 depth images don't get shown in the viewer. Instead we get the following on logs in the terminal:

2022-12-23T12:22:46.423032Z  WARN re_viewer::misc::caches::tensor_image_cache: Bad image "tensor [270, 480]": Don't know how to turn a tensor of shape=[270, 480] and dtype=F64 into an image
@nikolausWest nikolausWest mentioned this issue Dec 23, 2022
Merged
3 tasks
@jleibs
Copy link
Member

jleibs commented Feb 16, 2023

This doesn't just apply to depth images but to any f64 monochrome image.

@emilk emilk added the ui concerns graphical user interface label Feb 24, 2023
@teh-cmc teh-cmc self-assigned this Feb 28, 2023
@teh-cmc
Copy link
Member

teh-cmc commented Feb 28, 2023 •
edited
Loading

This applies to any image shaped tensors, whether it's depth or albedo.

ClassicTensor::as_dynamic_image doesn't handle f64s at all.

Also very related to #1435 and #1436

@emilk emilk added the good first issue Good for newcomers label Feb 28, 2023
@emilk emilk assigned emilk and unassigned teh-cmc Apr 4, 2023
@emilk
Copy link
Member

emilk commented Apr 4, 2023

Closed by #1686

@emilk emilk closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
good first issue Good for newcomers ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@emilk @nikolausWest @teh-cmc @jleibs