Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing should ever query re_data_store directly #6017

Open
teh-cmc opened this issue Apr 17, 2024 · 1 comment
Open

Nothing should ever query re_data_store directly #6017

teh-cmc opened this issue Apr 17, 2024 · 1 comment
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Apr 17, 2024

These low-level APIs are only meant to be used as building blocks for the higher-level query APIs.

Everything else should go through the query crates, in order to try and centralize/share as much as possible of all the logic that goes on top of fetching cells (resolving promises, handling errors, handling nullability, etc).

@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 😤 annoying Something in the UI / SDK is annoying to use 🔍 re_query affects re_query itself labels Apr 17, 2024
@teh-cmc teh-cmc self-assigned this Apr 17, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Apr 29, 2024

I made some progress on this but quickly realized there was much more tech debt than I anticipated on this front.

I don't want to dive into yet another big refactoring right now, so postponing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself
Projects
None yet
Development

No branches or pull requests

1 participant