Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide implementation detail past_viewer_recommendations from ViewportBlueprintArchetype #5431

Open
Wumpf opened this issue Mar 8, 2024 · 0 comments
Labels
🪳 bug Something isn't working 🛑 controversial 📖 documentation Improvements or additions to documentation

Comments

@Wumpf
Copy link
Member

Wumpf commented Mar 8, 2024

We should split internal implementation details like this out into a separate unlisted archetype (maybe another sub-archetype?) -- there's no reason for a user to be aware of this.

Originally posted by @jleibs in #5419 (comment)

The concern is that the past_viewer_recommendations field on ViewportBlueprint archetype is confusing to users.
Note that as of writing there's some disagreement both on the severity of that and the strategy of how to deal with this.

@Wumpf Wumpf added 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation 🛑 controversial labels Mar 8, 2024
@Wumpf Wumpf changed the title Hide implementation detail past_viewer_recommendations from `ViewportBlueprintArchetype Hide implementation detail past_viewer_recommendations from ViewportBlueprintArchetype Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🛑 controversial 📖 documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant