Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary cache: don't denormalize auto-generated instance keys #4733

Closed
teh-cmc opened this issue Jan 8, 2024 · 0 comments · Fixed by #5581
Closed

Primary cache: don't denormalize auto-generated instance keys #4733

teh-cmc opened this issue Jan 8, 2024 · 0 comments · Fixed by #5581
Assignees
Labels
🚀 performance Optimization, memory use, etc 🔍 re_query affects re_query itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jan 8, 2024

The primary cache currently treats all components the same way, it's completely unaware of semantics.

A side-effect of this is that it will denormalize instance keys just like it will denormalize any other component: i.e. it stores the result of applying all the join, implicit and splat logic.
That means that if you have 1 million implicit instance keys, they will actually be materialized in the cache and take ~7.6MiB of space.

@teh-cmc teh-cmc added 🔍 re_query affects re_query itself 🚀 performance Optimization, memory use, etc labels Jan 8, 2024
@teh-cmc teh-cmc self-assigned this Jan 18, 2024
@teh-cmc teh-cmc closed this as completed in 20dc298 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 performance Optimization, memory use, etc 🔍 re_query affects re_query itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant