Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove entities_determined_by_user logic and explicitly track "already added heuristic space views" #4557

Closed
jleibs opened this issue Dec 15, 2023 · 1 comment
Closed

Remove entities_determined_by_user logic and explicitly track "already added heuristic space views" #4557

jleibs opened this issue Dec 15, 2023 · 1 comment
Labels
🟦 blueprint The data that defines our UI

Comments

@jleibs
Copy link
Member

jleibs commented Dec 15, 2023 •
edited
Loading

Entities_determined_by_user is an awkward component.

It shouldn't show up in the user-facing Archetype (obviously if a user is building the archetype it's user-edited) and the need to manually set it on edits is fragile.

Proposal: instead track a hash of (SpaceViewClass, Query) for all space-views that have ever been added via the heuristics.

If it's ever been added, we never need to add it again automatically.
@jleibs jleibs added the 🟦 blueprint The data that defines our UI label Dec 15, 2023
@jleibs jleibs mentioned this issue Dec 15, 2023
Merged
4 tasks
@jleibs
Copy link
Member Author

jleibs commented Mar 11, 2024

Resolved by #5419

@jleibs jleibs closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jleibs