Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextDocument doesn't handle "visible history" #3510

Open
Tracked by #4107
nikolausWest opened this issue Sep 28, 2023 · 3 comments
Open
Tracked by #4107

TextDocument doesn't handle "visible history" #3510

nikolausWest opened this issue Sep 28, 2023 · 3 comments
Labels
😤 annoying Something in the UI / SDK is annoying to use 🍏 primitives Relating to Rerun primitives ui concerns graphical user interface
Milestone

Comments

@nikolausWest
Copy link
Member

It's currently possible to set visible history for Text components that are shown in a TextDocument view, but nothing changes in the view when you do. A reasonable solution would be to either disable the option and have a separate view type that aggregates multiple Text instances, or to just append the strings returned by visual history.

How to reproduce

import rerun as rr

rr.init("rerun_example_text_stream", spawn=True)

rr.log("text_stream", rr.TextDocument("The start of "))
rr.log("text_stream", rr.TextDocument("a longer "))
rr.log("text_stream", rr.TextDocument("sentence that "))
rr.log("text_stream", rr.TextDocument("ends with."))
Screenshot 2023-09-28 at 11 33 31
@nikolausWest nikolausWest added 😤 annoying Something in the UI / SDK is annoying to use 🍏 primitives Relating to Rerun primitives labels Sep 28, 2023
@nikolausWest nikolausWest added this to the 0.10 Polish milestone Sep 28, 2023
@abey79
Copy link
Member

abey79 commented Nov 3, 2023

The plan is to add this at the space view level (instead of datagroups/entities like in 2d/3d space views).

@nikolausWest
Copy link
Member Author

The plan is to add this at the space view level (instead of datagroups/entities like in 2d/3d space views).

Were is this plan written down? I'm sure there is a good reason but it does seem like it would be nice to do it in the same way for all things

@abey79
Copy link
Member

abey79 commented Nov 6, 2023

Here: #4044

It was a post-stand-up decision.

@abey79 abey79 added the ui concerns graphical user interface label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🍏 primitives Relating to Rerun primitives ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

2 participants