Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra file-dialog step on web #3197

Open
nikolausWest opened this issue Sep 4, 2023 · 1 comment
Open

Remove extra file-dialog step on web #3197

nikolausWest opened this issue Sep 4, 2023 · 1 comment
Labels
😤 annoying Something in the UI / SDK is annoying to use ui concerns graphical user interface 🕸️ web regarding running the viewer in a browser

Comments

@nikolausWest
Copy link
Member

When you try to open an rrd file in the web viewer, it opens an intermediate file modal before opening the system file dialog. The intermediate modal both isn't styled like the rest of Rerun (makes it look super ugly) and seems like an unnecessary step from a user's point of view. On native we just open the system file dialog directly.

Screenshot 2023-09-04 at 12 50 48

@nikolausWest nikolausWest added 🕸️ web regarding running the viewer in a browser ui concerns graphical user interface 😤 annoying Something in the UI / SDK is annoying to use labels Sep 4, 2023
@jprochazk
Copy link
Member

jprochazk commented Sep 4, 2023

We can fix the style, but removing the modal requires PolyMeilex/rfd#129 (or similar fix for PolyMeilex/rfd#128)

@abey79 abey79 added this to the 0.9.1 milestone Oct 9, 2023
@jleibs jleibs removed this from the 0.9.1 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use ui concerns graphical user interface 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

No branches or pull requests

4 participants