Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable roundtrip tests for doc examples #3177

Closed
teh-cmc opened this issue Sep 1, 2023 · 1 comment
Closed

Enable roundtrip tests for doc examples #3177

teh-cmc opened this issue Sep 1, 2023 · 1 comment
Labels
examples Issues relating to the Rerun examples 🔨 testing testing and benchmarks

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Sep 1, 2023

With #3172 we now catch doc examples that crash altogether, but that doesn't cover all the cases I've found where the examples did run but logged nonsensical data.

Building on top of #3172 it should be fairly straightforward to enable roundtrip tests among doc examples.
@teh-cmc teh-cmc added 🔨 testing testing and benchmarks examples Issues relating to the Rerun examples labels Sep 1, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Sep 7, 2023

Fixed by #3204

@teh-cmc teh-cmc closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
examples Issues relating to the Rerun examples 🔨 testing testing and benchmarks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teh-cmc