Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show image in 3D space view if there's a pinhole camera #3092

Closed
Wumpf opened this issue Aug 24, 2023 · 1 comment
Closed

Only show image in 3D space view if there's a pinhole camera #3092

Wumpf opened this issue Aug 24, 2023 · 1 comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself

Comments

@Wumpf
Copy link
Member

Wumpf commented Aug 24, 2023 •
edited
Loading

Right now if you log an image and put it into a 3D space view, we'll draw a rectangle expanding into X and Y at the origin with pixels being unit size. This is almost never what you want it want and completely messes up heuristics as it enlarges the "extended bounding box".

This can easily happen by accident if you first log an image and then a pinhole camera!
@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 😤 annoying Something in the UI / SDK is annoying to use labels Aug 24, 2023
@emilk emilk changed the title Don't show image in 3D space view if there's no pinhole camera (breaks bounding box even if seen briefly) Only show image in 3D space view if there's a pinhole camera Aug 24, 2023
@jleibs jleibs mentioned this issue Oct 10, 2023
Closed
@jleibs
Copy link
Member

jleibs commented Oct 20, 2023

Resolved by: #3822

@jleibs jleibs closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wumpf @jleibs