Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement deprecation_reason attribute #2367

Closed
teh-cmc opened this issue Jun 11, 2023 · 0 comments · Fixed by #5102
Closed

Implement deprecation_reason attribute #2367

teh-cmc opened this issue Jun 11, 2023 · 0 comments · Fixed by #5102
Labels
codegen/idl

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 11, 2023

Flatbuffers' builtin deprecated attribute is nice, but it's just a boolean.

We'd like to have an additional optional deprecation_reason attribute where we can explain why if we want to.

(Or maybe we just modify reflection.fbs to use string instead...? 😬)
@teh-cmc teh-cmc changed the title Impement deprecation_reason attribute Implement deprecation_reason attribute Jun 11, 2023
@Wumpf Wumpf mentioned this issue Feb 7, 2024
Merged
5 tasks
@Wumpf Wumpf closed this as completed in 52461cc Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen/idl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark TimeSeriesScalar as deprecated in all SDKs and documentation rerun-io/rerun
1 participant
@teh-cmc