Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordingStream::set_time_* are not automatically used as documented #2238

Closed
kpreid opened this issue May 28, 2023 · 1 comment
Closed

RecordingStream::set_time_* are not automatically used as documented #2238

kpreid opened this issue May 28, 2023 · 1 comment
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 🦀 Rust API Rust logging API

Comments

@kpreid
Copy link
Collaborator

kpreid commented May 28, 2023

Description
The Rust documentation says that the time in RecordingStream::{set_time_sequence, set_time_seconds, set_time_nanos} will be “used for all subsequent logging performed from this same thread”. However, it is not. The timeline name I pass to set_time_sequence() does not appear in the viewer.

Rerun version
0.6.0

Additional context
Based on examining the code, it appears that the only effect they have is to change the output of RecordingStream::now(), but now() is not called automatically by anything outside of the python_bridge code. Perhaps it should be automatically included in a similar fashion as the log_time timeline?

I have found that calling .with_timepoint(stream.now()) on each MsgSender causes the set time to appear in the viewer, which suffices as a workaround.

@kpreid kpreid added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels May 28, 2023
@Wumpf Wumpf added 🦀 Rust API Rust logging API 🏎️ Quick Issue Can be fixed in a few hours or less and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels May 29, 2023
@emilk
Copy link
Member

emilk commented Jun 27, 2023

Thanks for the report!

This should be fixed now by:

@emilk emilk closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 🦀 Rust API Rust logging API
Projects
None yet
Development

No branches or pull requests

3 participants