Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the repository less unix-centric #2200

Closed
3 tasks done
jprochazk opened this issue May 24, 2023 · 3 comments
Closed
3 tasks done

Make the repository less unix-centric #2200

jprochazk opened this issue May 24, 2023 · 3 comments
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🪟 windows Problems specific to the Windows OS

Comments

@jprochazk
Copy link
Member

jprochazk commented May 24, 2023

A lot of tooling in this repository assumes that:

  • bash exists (and that the user's shell understands hashbangs)
  • symlinks just work ™️

I think removing these two assumptions will make the repository much more accessible to Windows users.

  • scripts/setup* don't work on Windows, meaning they can't easily install required tooling
  • re_web_viewer_server is configured to fetch the web_viewer files via a symlink which doesn't work when the repository is freshly cloned
  • a lot of just recipes use bash (such as py-build, which is central to everything regarding the rerun wheel)

More investigation needs to be done to find all the other things which don't work on Windows out of the box.

@jprochazk jprochazk added 🧑‍💻 dev experience developer experience (excluding CI) 🪟 windows Problems specific to the Windows OS labels May 24, 2023
@jprochazk jprochazk mentioned this issue May 24, 2023
22 tasks
@emilk
Copy link
Member

emilk commented Jun 7, 2023

The instructions for Windows were improved in #2319

@jprochazk
Copy link
Member Author

jprochazk commented Nov 28, 2023

@Wumpf what's your experience like now? Are there any remaining snags?

I've had great success using pixi on Windows/Mac for everything. It Just Works™️, and I haven't had to manually run the contents of any bash script yet. Unless you object, I would be fine with closing this now (especially since further progress for pixi is tracked elsewhere)

@Wumpf
Copy link
Member

Wumpf commented Nov 28, 2023

Yeah let's close this. There's still some details that don't work like for example roundtrip test scripts aren't function yet on Windows and various scripts under /scripts/ don't work yet. just works by now but isn't great (looking forward to remove it completely)
The symlink in re_web_viewer isn't reaaaally a problem if git is configured correctly on windows. There's a note on BUILD.md by now

@Wumpf Wumpf closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🪟 windows Problems specific to the Windows OS
Projects
None yet
Development

No branches or pull requests

3 participants