Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re_build_build_info: PR builds fail in CI #2172

Closed
jleibs opened this issue May 19, 2023 · 2 comments
Closed

re_build_build_info: PR builds fail in CI #2172

jleibs opened this issue May 19, 2023 · 2 comments
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI)

Comments

@jleibs
Copy link
Member

jleibs commented May 19, 2023

See for example:
https://github.com/rerun-io/rerun/actions/runs/5024217902/jobs/9009702716?pr=2161

Specific error:

  --- stderr
  thread 'main' panicked at 'Failed to run 'git ["symbolic-ref", "--short", "HEAD"]':

  fatal: ref HEAD is not a symbolic ref

  ', crates/re_build_build_info/src/lib.rs:103:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Error: The process '/usr/local/cargo/bin/cargo' failed with exit code 101

I believe is another problem stemming from similar conditions as what caused:

In this particular case, during certain pull-request builds, the build does not take place on the branch commit, but rather an ephemeral merge-commit derived from merging the PR into main.

However, regardless, re_build_build_info needs to be robust to all manner of weird git environments.

I was hoping merging main into the branch would prevent this from happening but it seems not to be the case.

@jleibs jleibs added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team labels May 19, 2023
@jleibs jleibs changed the title re_build_build_info: PR builds fail in CI when not fully up-to-date with main re_build_build_info: PR builds fail in CI May 19, 2023
@jleibs jleibs added 🧑‍💻 dev experience developer experience (excluding CI) and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels May 19, 2023
@emilk
Copy link
Member

emilk commented May 19, 2023

Already broken in #2173

@emilk
Copy link
Member

emilk commented May 19, 2023

This was because I pushed a ill-thought-through assert to the PR in question. I'll do something better in #2173 instead

@emilk emilk closed this as completed May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

No branches or pull requests

2 participants