Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused python recording streams #2116

Open
teh-cmc opened this issue May 15, 2023 · 0 comments
Open

Drop unused python recording streams #2116

teh-cmc opened this issue May 15, 2023 · 0 comments
Labels
🐍 Python API Python logging API

Comments

@teh-cmc
Copy link
Member

teh-cmc commented May 15, 2023

RecordingStreams created from Python have their lifetimes managed by the Rust SDK: this is important as we cannot have Drop implementations running at arbitrary points in time depending on what the Python GC happens to be doing.

The one downside to this is that these recordings are never really dropped, they are merely disconnected, which means e.g. their batching thread is still running for no reason.

In 99.9% of cases this is completely irrelevant since all these threads do is sleeping, but still it'd be nice to clean up at some point.

@teh-cmc teh-cmc added the 🐍 Python API Python logging API label May 15, 2023
@teh-cmc teh-cmc changed the title Dropped unused python recordings Drop unused python recording streams May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐍 Python API Python logging API
Projects
None yet
Development

No branches or pull requests

1 participant