Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPEGs not decoded when hovering #1877

Closed
emilk opened this issue Apr 17, 2023 · 0 comments · Fixed by #1884
Closed

JPEGs not decoded when hovering #1877

emilk opened this issue Apr 17, 2023 · 0 comments · Fixed by #1884
Assignees
@emilk
Labels
🪳 bug Something isn't working

Comments

@emilk
Copy link
Member

emilk commented Apr 17, 2023

image (2)

I think DecodeCache should return a struct DecodedTensor(pub Tensor) newtype, and use DecodedTensor when uploading to GPU etc, to enforce at compile-time to remember to decode all tensors before displaying them
@emilk emilk added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 17, 2023
@emilk emilk self-assigned this Apr 17, 2023
This was referenced Apr 17, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🪳 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remember to decode JPEGs rerun-io/rerun
1 participant
@emilk