Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore: GC shouldn't have to return dropped RowIds #1804

Closed
Tracked by #1898
teh-cmc opened this issue Apr 10, 2023 · 1 comment
Closed
Tracked by #1898

datastore: GC shouldn't have to return dropped RowIds #1804

teh-cmc opened this issue Apr 10, 2023 · 1 comment
Labels
⛃ re_datastore affects the datastore itself 📺 re_viewer affects re_viewer itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Apr 10, 2023

The GC currently returns all the RowIds that were purged so that secondary datastructures in the viewer can be purged in turn.

But these secondary datastructures shouldn't be indexed by RowId to begin with but by time instead, making it possible to purge them using cut off times (like we do for e.g. the timeline widget).

@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 📺 re_viewer affects re_viewer itself labels Apr 10, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Nov 7, 2023

Cutoff times are Impossible now that the GC is driven by RowId order (clients' wall-clocks), which is the only solution we've found to fairly distribute GCs across timelines.

Individual timestamps are possible, and is in fact what we're already doing in most cases.

@teh-cmc teh-cmc closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛃ re_datastore affects the datastore itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

No branches or pull requests

1 participant