Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore: don't dump autogenerated keys #1793

Closed
Tracked by #1898
teh-cmc opened this issue Apr 6, 2023 · 0 comments · Fixed by #6104
Closed
Tracked by #1898

datastore: don't dump autogenerated keys #1793

teh-cmc opened this issue Apr 6, 2023 · 0 comments · Fixed by #6104
Assignees
@teh-cmc
Labels
📉 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Apr 6, 2023

DataStore::to_data_tables should detect and filter out instance keys that were auto-generated when dumping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
📉 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove instance keys and explicit splatting everywhere rerun-io/rerun
1 participant
@teh-cmc