Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore: implement shared slices for autogenerated keys #1777

Closed
Tracked by #1898
teh-cmc opened this issue Apr 5, 2023 · 2 comments · Fixed by #6104
Closed
Tracked by #1898

datastore: implement shared slices for autogenerated keys #1777

teh-cmc opened this issue Apr 5, 2023 · 2 comments · Fixed by #6104
Assignees
@teh-cmc
Labels
📉 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Apr 5, 2023

suggested by @emilk in #1727 (comment)
@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 📉 performance Optimization, memory use, etc labels Apr 5, 2023
@teh-cmc teh-cmc mentioned this issue Apr 18, 2023
Closed
23 tasks
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 23, 2023

Done.

@teh-cmc teh-cmc closed this as completed Oct 23, 2023
@teh-cmc teh-cmc mentioned this issue Dec 12, 2023
Closed
18 tasks
@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 2, 2024 •
edited
Loading

❌ Not done: this is about shared slices, not cached slices.

@teh-cmc teh-cmc reopened this Jan 2, 2024
@teh-cmc teh-cmc self-assigned this Mar 27, 2024
@teh-cmc teh-cmc mentioned this issue Mar 27, 2024
Closed
@teh-cmc teh-cmc mentioned this issue Apr 24, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
📉 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove instance keys and explicit splatting everywhere rerun-io/rerun
1 participant
@teh-cmc