Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Arrows without radius doesn't show anything #1708

Closed
Wumpf opened this issue Mar 25, 2023 · 0 comments · Fixed by #1720
Closed

Logging Arrows without radius doesn't show anything #1708

Wumpf opened this issue Mar 25, 2023 · 0 comments · Fixed by #1720
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself

Comments

@Wumpf
Copy link
Member

Wumpf commented Mar 25, 2023

Minimal repro:

fn run(mut session: rerun::Session) -> Result<(), rerun::MsgSenderError> {
    rerun::MsgSender::new("my_points")
        .with_component(&[rerun::components::Arrow3D {
            origin: rerun::components::Vec3D::new(0.0, 0.0, 0.0),
            vector: rerun::components::Vec3D::new(0.0, 10.0, 1.0),
        }])?
        .send(&mut session)
}

fn main() {
    let session = rerun::Session::init("arrow", true);
    session.spawn(run).unwrap();
}

Need to add .with_component(&[rerun::components::Radius(1.0)])? to see anything. Also happens in python!

Had a brief look in our code: I think the problem is that LineStripFlags::get_triangle_cap_tip_length doesn't deal with auto size correctly, but haven't given it much thought. In any case the issue is bound to be in Arrows3DPart

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself labels Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant