Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding boxes are half the size they are supported to be #1701

Closed
Tracked by #1753
jleibs opened this issue Mar 23, 2023 · 2 comments · Fixed by #1761
Closed
Tracked by #1753

Bounding boxes are half the size they are supported to be #1701

jleibs opened this issue Mar 23, 2023 · 2 comments · Fixed by #1761
Assignees
Labels
🪳 bug Something isn't working good first issue Good for newcomers 🍏 primitives Relating to Rerun primitives 🐍 Python API Python logging API

Comments

@jleibs
Copy link
Member

jleibs commented Mar 23, 2023

Documentation clearly indicates bounding box dimensions are specified in half-sizes:
https://ref.rerun.io/docs/python/v0.3.0/common/spatial_primitives/#rerun.log_obb

Sample code:

rr.log_obb("world/obb", [1, 2, 3], [0, 0, 0], None, color=[255, 0, 0])

expected_corners = [[d0, d1, d2] for d0 in (-1, 1) for d1 in (-2, 2) for d2 in (-3, 3)]
rr.log_points("world/corners", positions=expected_corners, colors=[0, 255, 0])

However, the resultant bounding box appears to have sides of the provided dimensions:
image

@jleibs jleibs added 🪳 bug Something isn't working 🍏 primitives Relating to Rerun primitives good first issue Good for newcomers labels Mar 23, 2023
@nikolausWest
Copy link
Member

Does #1749 close this or do we also need to make updates to examples or elsewhere?

@emilk emilk added the 🐍 Python API Python logging API label Apr 3, 2023
@emilk
Copy link
Member

emilk commented Apr 3, 2023

Make sure we update all example and docs too

@emilk emilk self-assigned this Apr 4, 2023
@emilk emilk mentioned this issue Apr 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working good first issue Good for newcomers 🍏 primitives Relating to Rerun primitives 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants