Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component should be a single trait #1694

Closed
Tracked by #1899
teh-cmc opened this issue Mar 23, 2023 · 1 comment
Closed
Tracked by #1899

Component should be a single trait #1694

teh-cmc opened this issue Mar 23, 2023 · 1 comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏹 arrow concerning arrow

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Mar 23, 2023

A Component is currently defined by three distinct traits:

  • Component
  • SerializableComponent
  • DeserializableComponent

This is annoying and pointlessly complicated: a component should always (de)serializable; but templates and HRTBs in arrow2-convert make things complicated in practice.

In the future, we'll probably want the component trait to be templated as well (trait Component<DataType>), to support our upcoming (component, datatype) datamodel. See #1595.
@teh-cmc teh-cmc added 🏹 arrow concerning arrow 😤 annoying Something in the UI / SDK is annoying to use labels Mar 23, 2023
@teh-cmc teh-cmc mentioned this issue Mar 23, 2023
Merged
7 tasks
@teh-cmc teh-cmc mentioned this issue Apr 18, 2023
Closed
7 tasks
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 9, 2023

Fixed by our new APIs.

@teh-cmc teh-cmc closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏹 arrow concerning arrow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teh-cmc