Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whenever the browser looses focus, camera rotates on click+drag #1681

Closed
Wumpf opened this issue Mar 23, 2023 · 4 comments · Fixed by #1715
Closed

Whenever the browser looses focus, camera rotates on click+drag #1681

Wumpf opened this issue Mar 23, 2023 · 4 comments · Fixed by #1715
Assignees
@Wumpf
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release 🕸️ web regarding running the viewer in a browser

Comments

@Wumpf
Copy link
Member

Wumpf commented Mar 23, 2023

It seems browser-based rerun thinks the Alt modifier key is pressed until one presses & releases it. This causes camera control to rotate on drag whenever the browser looses focus. Once I press alt it behaves as it should again.

May need to revert #1659 if we don't find a proper fix

Observed so far on Firefox @ Windows.
@Wumpf Wumpf added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser 🦟 regression A thing that used to work in an earlier release labels Mar 23, 2023
@emilk
Copy link
Member

emilk commented Mar 23, 2023

This sort of "sticky-modifiers" bug is very common. Please check if you have the issue on egui.rs:

Image

@Wumpf Wumpf self-assigned this Mar 27, 2023
@Wumpf
Copy link
Member Author

Wumpf commented Mar 27, 2023 •
edited
Loading

confirmed that it is a sticky modifier problem in egui

@emilk
Copy link
Member

emilk commented Mar 27, 2023

@emilk emilk mentioned this issue Mar 27, 2023
Merged
1 task
@emilk
Copy link
Member

emilk commented Mar 31, 2023

Fixed upstream in emilk/egui#2857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change roll-shortcut from ALT to SHIFT rerun-io/rerun
2 participants
@emilk @Wumpf