Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min-max range for Turbo colormap doesn't make sense for depth images #1588

Closed
Tracked by #1586
nikolausWest opened this issue Mar 14, 2023 · 6 comments
Closed
Tracked by #1586
Assignees
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release

Comments

@nikolausWest
Copy link
Member

nikolausWest commented Mar 14, 2023

Depth images logged as int16 currently get a way too high-max value for colormaps (Turbo only in 2D views). This makes the colormaps close to useless as they end up giving close to uniform colors.

Examples:
2D view
Screenshot 2023-03-14 at 17 01 06

Same depth image backprojected with Turbo colormap
Screenshot 2023-03-14 at 17 00 49

@nikolausWest nikolausWest added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release labels Mar 14, 2023
@emilk emilk self-assigned this Mar 23, 2023
@emilk
Copy link
Member

emilk commented Mar 23, 2023

I fail to reproduce.

This is nyud, with the points invisible, and Backproject Depth turned on:

image

The turbo colormap works well, and the 2D view has no colormap, since we haven't gotten to that yet:

@nikolausWest
Copy link
Member Author

@emilk

I'll get an easier repro for you asap but in the mean time, has something changed so we don't use turbo by default for depth images? We set turbo as default for depth images here:

@emilk
Copy link
Member

emilk commented Mar 23, 2023

We seem to only use it onlyfor float depth images, not integer depth images. I can make a fix for that.

@nikolausWest
Copy link
Member Author

For repro, just try:

@emilk
Copy link
Member

emilk commented Mar 23, 2023

arkitscenes have somehow been fixed by my recent PRs:

image

I'll merge main into the branch

@emilk emilk closed this as completed Mar 23, 2023
@nikolausWest
Copy link
Member Author

arkitscenes have somehow been fixed by my recent PRs:

Fantastic! Best kind of fix =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

No branches or pull requests

2 participants