Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh instancing/batching is broken #1530

Closed
Wumpf opened this issue Mar 7, 2023 · 0 comments · Fixed by #1657
Closed

Mesh instancing/batching is broken #1530

Wumpf opened this issue Mar 7, 2023 · 0 comments · Fixed by #1657
Assignees
@teh-cmc
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself

Comments

@Wumpf
Copy link
Member

Wumpf commented Mar 7, 2023

We're rendering only one mesh per drawcall right now despite our instancing machinery. The group_by https://github.com/rerun-io/rerun/blob/main/crates/re_renderer/src/renderer/mesh_renderer.rs#L166 on the mesh_renderer instance creation doesn't seem to group correctly - apparently compare methods on the mesh handles don't work as expected.
@Wumpf Wumpf added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself labels Mar 7, 2023
@teh-cmc teh-cmc self-assigned this Mar 21, 2023
@teh-cmc teh-cmc mentioned this issue Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

renderer: fix the groupby logic in mesh instancing rerun-io/rerun
2 participants
@Wumpf @teh-cmc