Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build universal wheels on Mac #1442

Closed
emilk opened this issue Feb 28, 2023 · 1 comment · Fixed by #1499
Closed

Don't build universal wheels on Mac #1442

emilk opened this issue Feb 28, 2023 · 1 comment · Fixed by #1499
Assignees
@Wumpf
Labels
🚀 performance Optimization, memory use, etc 🐍 Python API Python logging API ⛴ release Related to shipping or publishing

Comments

@emilk
Copy link
Member

emilk commented Feb 28, 2023 •
edited
Loading

Our Mac wheels are universal, i.e. work on both x64 and aarch64. This effectively doubles their size, which is the problem.

So let's build one x64 wheel and one aarch64 wheel for mac, and publish both.
@emilk emilk added 🐍 Python API Python logging API 🚀 performance Optimization, memory use, etc ⛴ release Related to shipping or publishing labels Feb 28, 2023
@Wumpf Wumpf self-assigned this Mar 2, 2023
@Wumpf Wumpf mentioned this issue Mar 3, 2023
Merged
2 tasks
@Wumpf
Copy link
Member

Wumpf commented Mar 3, 2023

Wheel build works. Arm wheel tested and confirmed working. Still need to test intel mac wheel!

@Wumpf Wumpf reopened this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🚀 performance Optimization, memory use, etc 🐍 Python API Python logging API ⛴ release Related to shipping or publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ci] Separate mac wheels & trigger wheel build from ui rerun-io/rerun
3 participants
@emilk @Wumpf @nikolausWest