Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch data ingestion #1395

Closed
emilk opened this issue Feb 24, 2023 · 2 comments
Closed

Batch data ingestion #1395

emilk opened this issue Feb 24, 2023 · 2 comments
Labels
enhancement New feature or request 📉 performance Optimization, memory use, etc 🐍 Python API Python logging API ⛃ re_datastore affects the datastore itself 🦀 Rust API Rust logging API

Comments

@emilk
Copy link
Member

emilk commented Feb 24, 2023

Currently each call to log_point or similar results in at least one LogMsg. This is wasteful in time and memory. It would be much better to batch calls so that we only send a new LogMsg every 50ms or so.
@emilk emilk added enhancement New feature or request 🐍 Python API Python logging API 🦀 Rust API Rust logging API ⛃ re_datastore affects the datastore itself 📉 performance Optimization, memory use, etc labels Feb 24, 2023
@emilk emilk mentioned this issue Feb 24, 2023
Closed
@emilk
Copy link
Member Author

emilk commented Mar 9, 2023 •
edited
Loading

A good example of why batching is important is just py-build && examples/python/clock/main.py --steps 250000 --save clock_250k.rrd - this has become much slower to run (Python) and to ingest (Rust) since switching to Arrow.

@emilk emilk mentioned this issue Mar 20, 2023
Merged
@emilk
Copy link
Member Author

emilk commented Mar 20, 2023

Dup of #1619

@emilk emilk closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request 📉 performance Optimization, memory use, etc 🐍 Python API Python logging API ⛃ re_datastore affects the datastore itself 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emilk