Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add procedure around new dependencies #1344

Closed
emilk opened this issue Feb 17, 2023 · 0 comments · Fixed by #1431
Closed

Add procedure around new dependencies #1344

emilk opened this issue Feb 17, 2023 · 0 comments · Fixed by #1431
Assignees
Labels
🧑‍💻 dev experience developer experience (excluding CI) 📖 documentation Improvements or additions to documentation

Comments

@emilk
Copy link
Member

emilk commented Feb 17, 2023

Every new dependency is a liability which adds:

We should therefore have some procedures in place for adding new dependencies.

A good place to start is https://gist.github.com/repi/d98bf9c202ec567fd67ef9e31152f43f

In summary:

  • Each PR that adds a dependency should motivate that
  • When reviewing a PR (including your own), always check the diff of Cargo.lock
  • Use default-features = true when it makes sense

This should be documented in CONTRIBUTING.md

@emilk emilk added 📖 documentation Improvements or additions to documentation 🧑‍💻 dev experience developer experience (excluding CI) labels Feb 17, 2023
@emilk emilk self-assigned this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) 📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant