Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm blobs should have different names in debug vs. release #1327

Closed
teh-cmc opened this issue Feb 16, 2023 · 1 comment · Fixed by #1428
Closed

Wasm blobs should have different names in debug vs. release #1327

teh-cmc opened this issue Feb 16, 2023 · 1 comment · Fixed by #1428
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Feb 16, 2023

Our build scripts generate a wasm blob to embed into the web server, but right now this blob will be named identically whether you're building in debug or release... which can lead to pretty nasty bugs to track down (e.g. a background cargo check overwriting your release blob without you knowing...).

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser 😤 annoying Something in the UI / SDK is annoying to use labels Feb 16, 2023
@emilk emilk self-assigned this Feb 28, 2023
@emilk
Copy link
Member

emilk commented Mar 11, 2023

With this, we now include both the release and debug wasm files when we publish our crates, which more than doubles the crate size (the debug build is larger). Ideally we should only include the release build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants