Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_file!() must show the full path and its kind in case of error #1322

Closed
teh-cmc opened this issue Feb 15, 2023 · 0 comments · Fixed by #1339
Closed

include_file!() must show the full path and its kind in case of error #1322

teh-cmc opened this issue Feb 15, 2023 · 0 comments · Fixed by #1339
Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) 🔺 re_renderer affects re_renderer itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Feb 15, 2023

We've been chasing a nasty build issue with @jleibs and towards the end had to deal with this error:

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: No such file or directory (os error 2)', crates/re_renderer/src/renderer/mesh_renderer.rs:286:25
stack backtrace:
   0: rust_begin_unwind
             at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/panicking.rs:64:14
   2: core::result::unwrap_failed
             at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/result.rs:1791:5
   3: core::result::Result<T,E>::unwrap
[...]

which isn't too useful and had us look in all kinds of wrong directions until we realized that this was looking for an actual physical path, meaning this was mistakenly building in debug mode... something that should have been obvious by looking at the error.

include_file!() must indicate the full path and whether its virtual or physical when failing.

@teh-cmc teh-cmc added 🔺 re_renderer affects re_renderer itself 🧑‍💻 dev experience developer experience (excluding CI) 😤 annoying Something in the UI / SDK is annoying to use labels Feb 15, 2023
@teh-cmc teh-cmc changed the title FileResolver macros must show the full path and its kind in case of error include_file!() must show the full path and its kind in case of error Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant