Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that all buttons (from UI) follow the circulation policy #936

Closed
blankoworld opened this issue Apr 17, 2020 · 3 comments
Closed

Check that all buttons (from UI) follow the circulation policy #936

blankoworld opened this issue Apr 17, 2020 · 3 comments
Labels
f: circulation Concerns the circulation interface or backend

Comments

@blankoworld
Copy link
Contributor

Describe the issue
We should check in rero-ils-ui that all buttons follow the circulation policy.

In example the renewal button use a method that don't use the "patron_pid".
If, for any reason, the new "blocking user" functionnality disallow renewals in circulation policy, without the patron_pid the renewal button will not know that it's forbidden for this user to renew the loan.

@iGormilhit iGormilhit added the f: circulation Concerns the circulation interface or backend label Sep 16, 2020
@iGormilhit
Copy link

@AoNoOokami Can you confirm that we can close this?

@AoNoOokami
Copy link
Contributor

AoNoOokami commented Sep 16, 2020

First we must decide if a blocked patron can renew an item or not. And I think that only the example mentioned by Olivier is concerned, the other buttons in rero-ils-ui observe the permissions implemented in backend. So if the conditions change, the modification have to be done in backend only.

Edit: actually it's the same with renew button. The condition of display are defined in backend. However, there are no restrictions if the user is blocked for this moment.

@iGormilhit
Copy link

Yes, a blocked patron is able to renew its loans: https://tree.taiga.io/project/rero21-reroils/us/299

So, this is issue is considered as closed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

No branches or pull requests

3 participants