ui: display library name instead of code #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
approved these changes
Feb 20, 2020
BadrAly
approved these changes
Feb 20, 2020
* Changes the display in the document detailed view for holdings: the library name replace the library code. * Closes rero#776. * Fixes travis tests introduced by previous commits. Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
force-pushed
the
maj-fix-holding-display-location
branch
from
3f284cd to
51ba191
Compare
zannkukai
approved these changes
Feb 20, 2020
| @@ -299,7 +299,7 @@ def test_auto_checkin_else(client, librarian_martigny_no_email, lib_martigny, | |||
| assert item.status == ItemStatus.IN_TRANSIT | |||
|
|
|||
| record, actions = item.automatic_checkin() | |||
| assert actions == {'no': None} | |||
| assert 'no' in actions | |||
There was a problem hiding this comment.
To be perfect, you could add this line just below :
assert actions['no']['pid'] == loan_pid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
library name replace the library code.
Co-Authored-by: Johnny Mariéthoz [email protected]
Why are you opening this PR?
How to test?
Code review check list