Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to create a user with role "librarian" #771

Closed
pronguen opened this issue Feb 19, 2020 · 1 comment
Closed

Impossible to create a user with role "librarian" #771

pronguen opened this issue Feb 19, 2020 · 1 comment
Assignees
Labels
f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: user management
Milestone

Comments

@pronguen
Copy link
Contributor

Describe the issue
When I create a user (ie. a patron), in the patron editor, add the role librarian, but I cannot save, even if all fields marked with asterisk are filled. The fields related to role patron are displayed. If I fill these fields, I can save. Whatever information I fill, if I select the role librarian, I get an error when saving the record, and cannot edit this record any more.

To Reproduce

  1. Add a new patron/user
  2. Select role librarian
  3. Try to save
  4. Fill all fields, incl. patron fields
  5. Save and see error

Expected behavior

  • Patron fields or librarian fields are displayed only if the corresponding role is selected.
  • Saving a librarian is possible without filling patron fields

Software version
ilsdev + ilspilot
rero-ils version c236bc8
rero-ils-ui version 4fc4656d

@pronguen pronguen added this to the v0.6.0 milestone Feb 19, 2020
@iGormilhit iGormilhit added f: professional ui Professional interface f: user management f: editor Concerns editor based on JSON schema AND custom editor labels Feb 19, 2020
@benerken
Copy link
Contributor

benerken commented Feb 19, 2020

Should be solved by PR #773.
Tested locally and it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: user management
Projects
None yet
Development

No branches or pull requests

3 participants