Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications sent to the library (for printing) instead of the patron #2279

Closed
pronguen opened this issue Aug 9, 2021 · 3 comments · Fixed by #2312
Closed

Notifications sent to the library (for printing) instead of the patron #2279

pronguen opened this issue Aug 9, 2021 · 3 comments · Fixed by #2312
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: notifications p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.4.9

Comments

@pronguen
Copy link
Contributor

pronguen commented Aug 9, 2021 •
edited
Loading

Describe the bug

Some notifications (recall, availability) sent to the library (for printing) instead of the patron.

Moreover, it is sometimes sent to the wrong library and without addressee block (see example 2)

To Reproduce

We don't know yet how to reproduce it. See examples below.

Expected behavior

The patron notifications (recall, availability) are always sent to the patron if communication channel is e-mail.

Context

  • server: bib.rero.ch on 04.08.21
  • version: v1.4.6

Example 1

In this case the availability notification was sent to the library:

Example 2
In this case the availability notification was sent to the wrong library, should have been sent to the patron:

Von: [email protected] [email protected]
Gesendet: Montag, 9. August 2021 13:11
An: MEDIATHEK-WALLIS-BRIG [email protected]
Betreff: Invitation à retirer un document

Chère lectrice, cher lecteur,
Le document que vous avez demandé est maintenant disponible. Vous pouvez venir le retirer au bureau de prêt de la bibliothèque mentionnée ci-dessous.

Titre : Das Seelenleben des Kleinkindes und andere Beiträge zur Psychoanalyse / Melanie Klein Lieu de retrait : Sion - Médiathèque Valais
Titre : Narzissmus : eine Theorie der psychoanalytischen Behandlung narzisstischer Persönlichkeitsstörungen / Heinz Kohut Lieu de retrait : Sion - Médiathèque Valais

A retirer jusqu'au : 20.08.2021

Si le document n'est pas retiré dans les délais, il sera remis en circulation pour d'autres personnes.
Vous pouvez consulter votre compte et prolonger la durée de prêt de vos documents à l'adresse : https://bib.rero.ch/vs/patrons/profile

Avec nos compliments

SION - Médiathèque Valais
Rue de Lausanne 45, CP 182, CH - 1950 Sion
@pronguen pronguen added f: circulation Concerns the circulation interface or backend f: notifications bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels Aug 9, 2021
@pronguen pronguen added this to the v1.7.0 / sprint 47 milestone Aug 19, 2021
@zannkukai
Copy link
Contributor

Address block for mail notification has added into #2312 PR

@pronguen
Copy link
Contributor Author

@jma Here the issue about the location that is no more pick-up: #2162

@iGormilhit iGormilhit modified the milestones: v1.7.0, v1.4.9 Sep 1, 2021
@iGormilhit iGormilhit linked a pull request Sep 1, 2021 that will close this issue
notifications: fix notification problems #2312
Merged
7 tasks
@iGormilhit
Copy link

Solved by #2312.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: notifications p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.4.9
Development

Successfully merging a pull request may close this issue.

notifications: fix notification problems zannkukai/rero-ils
3 participants
@iGormilhit @pronguen @zannkukai