Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too much api calls when switching from checkin view to patron loan view #1179

Closed
AoNoOokami opened this issue Aug 25, 2020 · 3 comments
Closed

Too much api calls when switching from checkin view to patron loan view #1179

AoNoOokami opened this issue Aug 25, 2020 · 3 comments
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-Low Low priority stale Stale or no longer relevant

Comments

@AoNoOokami
Copy link
Contributor

AoNoOokami commented Aug 25, 2020 •
edited
Loading

Describe the bug
When going to patron loan view from checkin view, there are a lot of api calls to /api/patrons/ (see screenshot below).

To Reproduce
Steps to reproduce the behavior:

  1. Go to checkin view and open network tool
  2. Type patron barcode, for example 'kad001' to go to patron loan view
  3. Check the network window and see the api calls

Expected behavior
Only one api call is enough.
This may mean that there are missing unsubscribe in the process.

Context
Tell us on what server did you spotted the issue, using with browser.

Screenshots

api

Additional context
Add any other context about the problem here.
@AoNoOokami AoNoOokami added triage bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend enhancement Improvement of an existing feature and removed triage enhancement Improvement of an existing feature labels Aug 25, 2020
@iGormilhit
Copy link

@AoNoOokami Is this the cause of toast messages with unexpected information in the circulation module interface?

@AoNoOokami
Copy link
Contributor Author

@AoNoOokami Is this the cause of toast messages with unexpected information in the circulation module interface?

It may be linked. @zannkukai and @sebastiendeleze said that there are too much API calls when we were working around this bug and that should be improved.

@iGormilhit iGormilhit added the p-Low Low priority label Nov 26, 2020
This was referenced Dec 1, 2020
Closed
Merged
@PascalRepond PascalRepond added the stale Stale or no longer relevant label Mar 14, 2022
@PascalRepond
Copy link
Contributor

Cannot reproduce on v1.9.0. Has probably been fixed since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-Low Low priority stale Stale or no longer relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @AoNoOokami @PascalRepond