You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AoNoOokami opened this issue
Jul 15, 2020
· 3 comments
Labels
bugBreaks something but is not blockingf: editorConcerns editor based on JSON schema AND custom editorp-LowLow prioritystaleStale or no longer relevant
Describe the bug
It is possible to type char, for example 'a', 'b' or 'c', or even string, in integer-type fields when using the editor in Firefox. There is no validation error message to warn the user.
Example: provisionActivity.startDate - when adding a letter, the field validation message is "This field is required" ; when adding an integer with only one character (instead of 4), there is no field validation message but a global error on the form "The form contains errors.".
Example: partOf - year and pages have a validation (impossible to save a string not integer), but not numbering and volume (we can save a string not integer without error message, but they are not saved).
To Reproduce
Steps to reproduce the behavior:
Go to the document editor
Display 'part of' field
Type something in volume or issue field
The record can't be saved. There is no validation message to warn about the wrong type of data.
Expected behavior
It shouldn't be possible to type anything else than an integer in those fields.
Context
This is related to the behaviour of ngx-formly. Therefore, an issue was reported on the repo: ngx-formly/ngx-formly#2360
Screenshots
If applicable, add screenshots to help explain your problem.
The text was updated successfully, but these errors were encountered:
@AoNoOokamingx-formly/ngx-formly#2360 seems to be closed, but I still can reproduce it in v0.14.1. Is it because we have to update ngx-formly in ng-core?
I tested it on v0.15.0. There is an error if we type char in date 1 of provision activity field, but the message says: This field is required. If I type a date, for example `2020 the field is validated.
bugBreaks something but is not blockingf: editorConcerns editor based on JSON schema AND custom editorp-LowLow prioritystaleStale or no longer relevant
Describe the bug
It is possible to type char, for example 'a', 'b' or 'c', or even string, in integer-type fields when using the editor in Firefox. There is no validation error message to warn the user.
Example:
provisionActivity.startDate
- when adding a letter, the field validation message is "This field is required" ; when adding an integer with only one character (instead of 4), there is no field validation message but a global error on the form "The form contains errors.".Example:
partOf
- year and pages have a validation (impossible to save a string not integer), but not numbering and volume (we can save a string not integer without error message, but they are not saved).To Reproduce
Steps to reproduce the behavior:
Expected behavior
It shouldn't be possible to type anything else than an integer in those fields.
Context
This is related to the behaviour of ngx-formly. Therefore, an issue was reported on the repo: ngx-formly/ngx-formly#2360
Screenshots
If applicable, add screenshots to help explain your problem.
The text was updated successfully, but these errors were encountered: