Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete doesn't work if your search contains diactrictics #1042

Closed
AoNoOokami opened this issue Feb 24, 2020 · 3 comments
Closed

Autocomplete doesn't work if your search contains diactrictics #1042

AoNoOokami opened this issue Feb 24, 2020 · 3 comments
Labels
enhancement Improvement of an existing feature f: search p-Medium Medium priority (to be solved within 1-2 years)

Comments

@AoNoOokami
Copy link
Contributor

Describe the issue
Autocomplete doesn't work if your search contains diactrictics (try: réalité and realite)

To Reproduce
Steps to reproduce the behavior:

  1. Go to homepage
  2. Search with 'realite' keyword
  3. There is no autocomplete, no suggestions of result

Expected behavior
Autocomplete should work with diactrictics in the search

Software version
ilsdev.test.rero.ch
647a7f3
rero/rero-ils-ui@30e8cdd

@iGormilhit iGormilhit transferred this issue from rero/rero-ils-ui Jun 15, 2020
@iGormilhit iGormilhit added enhancement Improvement of an existing feature f: search labels Jun 15, 2020
@zannkukai
Copy link
Contributor

zannkukai commented Jun 26, 2020

Search with diacritics seems works well.
I had some issues with L' prefix before diacritics words.
Search with école return no result, search with l'école return 1 result.
Search with tête return 1 result (as expected)
Maybe the "apostrophe" isn't yet considered at a word separator into ES analyzer ?

Not an expert but it seems than basic standard tokenizer doesn't split words. Maybe it should be better to use icu_tokenizer ? There is a french blog post introducing some french specification here : https://jolicode.com/blog/construire-un-bon-analyzer-francais-pour-elasticsearch

@zannkukai
Copy link
Contributor

zannkukai commented Jun 26, 2020

Should a request with tete return tête results ?

@iGormilhit iGormilhit modified the milestones: v0.12.0, v0.13.0 Aug 11, 2020
@iGormilhit iGormilhit removed this from the v0.13.0 milestone Nov 3, 2020
@iGormilhit iGormilhit added the p-Medium Medium priority (to be solved within 1-2 years) label Nov 26, 2020
@pronguen
Copy link
Contributor

Seems to be solved: the suggestions include the diacritics. But the highlighted text in each suggestion does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature f: search p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Development

No branches or pull requests

4 participants