diff --git a/rero_ils/modules/organisations_libraries/utils.py b/rero_ils/modules/organisations_libraries/utils.py index 791c12d671..ad20bc9a23 100644 --- a/rero_ils/modules/organisations_libraries/utils.py +++ b/rero_ils/modules/organisations_libraries/utils.py @@ -66,16 +66,6 @@ def save_library(data, record_type, record_class, parent_pid=None): library = record_class.get_record_by_pid(pid) library.update(data, dbcommit=False, reindex=False) else: - if 'opening_hours' not in data: - data['opening_hours'] = [ - {"day": "monday", "is_open": False, "times": []}, - {"day": "tuesday", "is_open": False, "times": []}, - {"day": "wednesday", "is_open": False, "times": []}, - {"day": "thursday", "is_open": False, "times": []}, - {"day": "friday", "is_open": False, "times": []}, - {"day": "saturday", "is_open": False, "times": []}, - {"day": "sunday", "is_open": False, "times": []} - ] library = record_class.create(data, dbcommit=False, reindex=False) organisation.add_library(library) library.dbcommit(reindex=True) diff --git a/rero_ils/modules/utils.py b/rero_ils/modules/utils.py index ea63b7e758..004db510ad 100644 --- a/rero_ils/modules/utils.py +++ b/rero_ils/modules/utils.py @@ -82,7 +82,7 @@ def clean_dict_keys(data): if isinstance(data, list): to_return = [] for item in data: - if item is False: + if item is False or item == []: to_return.append(item) else: tmp = clean_dict_keys(item) @@ -94,7 +94,7 @@ def clean_dict_keys(data): if isinstance(data, dict): to_return = {} for k, v in data.items(): - if v is False: + if v is False or v == []: to_return[k] = v else: tmp = clean_dict_keys(v) diff --git a/rero_ils/templates/rero_ils/search.html b/rero_ils/templates/rero_ils/search.html index de3c514353..d2b569c7c4 100644 --- a/rero_ils/templates/rero_ils/search.html +++ b/rero_ils/templates/rero_ils/search.html @@ -63,7 +63,12 @@

{{_(record_type)}}

{%- endblock search_sort_select %} {%- block search_sort_order scoped %} {%- if record_type | resource_can_create and current_user | can_edit %} - {{_('Create')}} + {# TODO: Change this to local template resource to customize the link #} + {%- if record_type == 'lib' %} + {{_('Create')}} + {% else %} + {{_('Create')}} + {% endif %} {% endif %} {%- endblock search_sort_order %} diff --git a/run-tests.sh b/run-tests.sh index f631a2c796..4cfdebe40c 100755 --- a/run-tests.sh +++ b/run-tests.sh @@ -36,7 +36,7 @@ fi set -e pipenv check -i 36437 -pipenv run flask utils check_json tests rero_ils data +pipenv run flask utils check_json tests rero_ils/modules data pipenv run pydocstyle rero_ils tests docs pipenv run isort -rc -c -df --skip ui pipenv run check-manifest --ignore ".travis-*,docs/_build*,ui/admin/node_modules*,rero_ils/static/js/rero_ils/admin*" diff --git a/ui/admin/proxy.conf.json b/ui/admin/proxy.conf.json index 74aeee22a1..f142ca699a 100644 --- a/ui/admin/proxy.conf.json +++ b/ui/admin/proxy.conf.json @@ -43,5 +43,14 @@ "pathRewrite": { "^/static": "http://localhost:5000/static" } + }, + "/admin/lib/*": { + "target": "http://localhost:5000", + "secure": false, + "logLevel": "debug", + "changeOrigin": true, + "pathRewrite": { + "^/static": "http://localhost:5000/admin/lib" + } } } diff --git a/ui/admin/src/app/app.module.ts b/ui/admin/src/app/app.module.ts index 5b72fe2da2..317769080b 100644 --- a/ui/admin/src/app/app.module.ts +++ b/ui/admin/src/app/app.module.ts @@ -20,7 +20,7 @@ export function HttpLoaderFactory(http: HttpClient) { if (environment.production) { assets_prefix = '/static/js/rero_ils/admin/'; } - return new TranslateHttpLoader(http, assets_prefix+'assets/i18n/', '.json'); + return new TranslateHttpLoader(http, assets_prefix + 'assets/i18n/', '.json'); } diff --git a/ui/admin/src/app/libraries/exception-dates-edit/exception-dates-edit.component.html b/ui/admin/src/app/libraries/exception-dates-edit/exception-dates-edit.component.html index 02fa61b684..bbc5b75824 100644 --- a/ui/admin/src/app/libraries/exception-dates-edit/exception-dates-edit.component.html +++ b/ui/admin/src/app/libraries/exception-dates-edit/exception-dates-edit.component.html @@ -83,7 +83,7 @@